Please look at my JEP

[Mikael Vidstedt]

Andrew,

I looked through the JEP and have a few minor comments.

In the "Risks and Assumptions" section:

"Fort the PPC port Oracle created a staging repository to contain the changes that had been reviewed and approved."

I suggest a rephrase of this sentence to the following:

Similar to the PPC/AIX port, a staging forest owned by the AArch64 Port Project will be created (e.g. aarch64-port/stage) to contain changesets that have been Reviewed and approved.


I think that there may be a misunderstanding here:

"Oracle also created a private hudson instance for the staging repository, to build and test the changes. We would like something similar to happen for this project, but this has not yet been agreed and requires hardware to be provided."

For the PPC/AIX port, the Oracle instance only built and tested Oracle-supported configurations to understand impact of the PPC/AIX changes.  SAP and IBM were (and continue to be) responsible for building and testing the PPC/AIX port.

Oracle will use the same approach for AArch64 so providing hardware to Oracle will not be necessary.


In the "Dependencies" section:

"AArch64 hardware and operating system software. Red Hat will provide the latter."

Given the above, I don't believe that this is applicable.


After you make those changes, I'll list myself as a Reviewer and Endorser. The next step will be for you to move the JEP to "Submitted".

Cheers,
Mikael

On 2014-07-02 01:11, Andrew Haley wrote:
> Hi everybody,
>
> Please can someone review my JEP?
>
> It's very simple, and until we can get things moving this is
> blocking a significant contribution to OpenJDK.
>
> https://bugs.openjdk.java.net/browse/JDK-8044552
>
> Thanks,
> Andrew.
>
>
>
> On 19/06/14 15:27, Andrew Haley wrote:
>> The JEP is here:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8044552
>>
>> As you may know, we've been working on this port for some time.
>> It is now at the stage where it may be considered for inclusion
>> in OpenJDK.  It passes all its tests, and although there is still
>> some tidying up to do, I think we should move to the next stage.
>>
>> Thanks,
>> Andrew.
>>