RFR(S): 8050802: Update jprt runthese test suite to jck-8

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Jul 16 21:40:21 UTC 2014


Looks fine to me :)

Thanks,
Vladimir

On 7/16/14 2:06 PM, Mikael Vidstedt wrote:
>
> Vladimir,
>
> Per our conversation off-list I've updated the webrev to split up all
> the -Xcomp tests into -Xcomp_lang and -Xcomp_vm with the understanding
> that this will likely add some small amount to job times in favor of
> symmetry. New webrevs:
>
> top:
> http://cr.openjdk.java.net/~mikael/webrevs/8050802/webrev.01/top/webrev/
> hotspot:
> http://cr.openjdk.java.net/~mikael/webrevs/8050802/webrev.01/hotspot/webrev/
>
>
> Cheers,
> Mikael
>
> On 2014-07-15 19:05, Mikael Vidstedt wrote:
>>
>> Note, btw, that the reason why this linux-i586-fastdebug-Xcomp is the
>> culprit here is that that's the only platform where we're running
>> Xcomp on fastdebug, the other Xcomp are all on product.
>>
>> Cheers,
>> Mikael
>>
>> On 2014-07-15 18:40, Mikael Vidstedt wrote:
>>>
>>> From my empirical data the only test I've seen this "problem" with is
>>> the linux-i586-fastdebug-Xcomp; remember that there's a cost/overhead
>>> for setting up the individual tests too so splitting up the other
>>> Xcomp tests may actually make the job times longer.
>>>
>>> That said, if you feel that it's important for symmetry I can
>>> certainly do it.
>>>
>>> Cheers,
>>> Mikael
>>>
>>> On 2014-07-15 17:20, Vladimir Kozlov wrote:
>>>> Mikael,
>>>>
>>>> I think you should split Xcomp on all platforms (not only for
>>>> linux.i586) where it runs.
>>>>
>>>> thanks,
>>>> Vladimir
>>>>
>>>> On 7/15/14 3:59 PM, Mikael Vidstedt wrote:
>>>>>
>>>>> Please review the below change which switches the 'runThese' test
>>>>> suite
>>>>> over the new, jck-8 based 'runThese8' tests suite. The change also
>>>>> splits up the long running fastdebug-Xcomp test into two separate
>>>>> tests
>>>>> (fastdebug-Xcomp_lang and fastdebug-Xcomp_vm) to take advantage of the
>>>>> parallelism in jprt to reduce the job times further.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050802
>>>>> Webrev (hs-rt/ (top) repo):
>>>>> http://cr.openjdk.java.net/~mikael/webrevs/8050802/webrev.00/top/webrev/
>>>>>
>>>>> Webrev (hs-rt/hotspot repo):
>>>>> http://cr.openjdk.java.net/~mikael/webrevs/8050802/webrev.00/hotspot/webrev/
>>>>>
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Mikael
>>>>>
>>>
>>
>


More information about the hotspot-dev mailing list