RFR(M): 8050942 : PPC64: implement template interpreter for ppc64le
Alexander Smundak
asmundak at google.com
Fri Jul 18 00:58:17 UTC 2014
On Thu, Jul 17, 2014 at 3:20 AM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> I tested your change. Unfortunately it breaks our port. You need to fix Unsigned to
> Signed:
>
> --- a/src/cpu/ppc/vm/templateTable_ppc_64.cpp Wed Jul 16 16:53:32 2014 -0700
> +++ b/src/cpu/ppc/vm/templateTable_ppc_64.cpp Thu Jul 17 12:14:18 2014 +0200
> @@ -1929,7 +1929,7 @@
> // default case
> __ bind(Ldefault_case);
>
> - __ get_u4(Roffset, Rdef_offset_addr, 0, InterpreterMacroAssembler::Unsigned);
> + __ get_u4(Roffset, Rdef_offset_addr, 0, InterpreterMacroAssembler::Signed);
> if (ProfileInterpreter) {
> __ profile_switch_default(Rdef_offset_addr, Rcount/* scratch */);
> __ b(Lcontinue_execution);
Oops. Fixed. Which test was broken by this, BTW?
> If you want to, you can move loading the bci in this bytecode behind the loop.
Done.
> Could you please fix indentation of relocInfo::none in call_c? Should
> be aligned to call_c.
Done.
The revised patch is at
http://cr.openjdk.java.net/~asmundak/8050942/hotspot/webrev.01/
please take another look.
Sasha
More information about the hotspot-dev
mailing list