[8u40] 8047740: Add hotspot testset to jprt.properties

Mikael Vidstedt mikael.vidstedt at oracle.com
Fri Jul 18 06:05:15 UTC 2014


David,

Thanks for the review, I'll add the comment before committing!

Cheers,
Mikael

On 2014-07-17 19:09, David Holmes wrote:
> Hi Mikael,
>
> This looks good to me. One request: can you add an additional comment:
>
>  92 # i586 platforms have both client and server, but to allow for 
> overriding the exact configuration
>   93 # on a per-build flavor basis the value is set for the individual 
> build flavors
> + # All other platforms only build server, which is the default 
> setting from configure
>
> Thanks!
>
> As a reminder for other readers/reviewers/casual-observers, the JDK 
> testing is unchanged; the hotspot testing is as currently specified by 
> the hotspot jprt.properties files; the non-open platforms are all 
> handled in a non-open jprt.properties files. This doesn't add any JDK 
> testing when doing full builds and pushes.
>
> Thanks,
> David
>
>
> On 18/07/2014 5:49 AM, Mikael Vidstedt wrote:
>>
>> Please review this backport of 8047740 from 9 to 8u-dev. The backport is
>> almost the same as the original changeset - only the version (jdk9 vs
>> jdk8u20) is different, along with the corresponding
>> --with-update-version configure argument. Currently the update version
>> is set to '20' which matches what the corresponding
>> hotspot/make/jprt.properties file uses.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8047740
>> jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/9f96a36ef77c
>>
>> webrev (8udev):
>> http://cr.openjdk.java.net/~mikael/webrevs/8047740-8udev/webrev.00/webrev/ 
>>
>>
>> Cheers,
>> Mikael
>>



More information about the hotspot-dev mailing list