RFR (XXS): 8051378: AIX: Change "8030763: Validate global memory allocation" breaks the HotSpot build

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jul 18 18:57:31 UTC 2014


Looks good.

Alejandro suggested that I should push it into jdk8u/jdk8u-dev/hotspot 
where 8u11 was merged.

When the fix will be approved it will be pushed into 8u20 repo.

Thanks,
Vladimir

On 7/18/14 11:14 AM, Volker Simonis wrote:
> Hi,
>
> could somebody please review and sponsor the following tiny, AIX-only
> change which fixes the HotSpot build on AIX for the 8u20/8u-dev code
> lines:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8051378/
> https://bugs.openjdk.java.net/browse/JDK-8051378
>
> Details:
>
> Unfortunately the merging of 8u11 into 8u-dev and 8u20 broke the
> HotSpot build on AIX for those code lines.
>
> The fix is trivial - just remove the unused function
> os::set_error_file() in os_aix.cpp (as this has been done on the other
> platforms by 8030763)
>
> The webrev is against 8u20 but should apply equally well against 8u-dev.
>
> Actually, it sould also apply against jdk8u/hs-dev/ and if that helps
> it can also be pushed there first. That will in fact break the HotSpot
> build on AIX in jdk8u/hs-dev/ until it will be synced up with the 8u11
> changes, but I think that's not so important. It's much more important
> to get the fix into 8u20 in time.
>
> Thank you and best regards,
> Volker
>


More information about the hotspot-dev mailing list