RFR (L) 8044140: [TESTBUG] Create NMT (Native Memory Tracking) tests for NMT2

[Christian Tornqvist]

Hi George,

Except for the things Zhengyu mentioned, the only thing I have is if TEST.groups should have 2014 as copyright year as well? Otherwise it looks good, thanks for doing this :)

Thanks,
Christian

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of George Triantafillou
Sent: Thursday, May 29, 2014 1:20 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR (L) 8044140: [TESTBUG] Create NMT (Native Memory Tracking) tests for NMT2

Hi Zhengyu,

Thanks for your comments.

On 5/28/2014 1:25 PM, Zhengyu Gu wrote:
> Hi,
>
> JcmdScale.java:
>   There is no change, should not update copyright ...
Fixed.

>
> AutoshutdownNMT.java line #42
>
> 42        output.shouldContain("Unrecognized VM option 
> 'AutoshutdownNMT'");
>
> Should be
>
> 42        output.shouldContain("Unrecognized VM option 
> 'AutoShutdownNMT'");
>
>
> Also -XX:-AutoshutdownNMT => -XX:-AutoShutdownNMT
>
Fixed.

-George
>
> -Zhengyu
>
>
> On 5/28/2014 1:10 PM, George Triantafillou wrote:
>> Please review these new and modified tests for the redesigned Native 
>> Memory Tracking (NMT) functionality (8028541: Native Memory Tracking 
>> enhancement <https://bugs.openjdk.java.net/browse/JDK-8028541>).  NMT 
>> was redesigned internally to address scalability issues in the first 
>> implementation.  Existing functionality has not changed, with the 
>> exception of the removal of the "-AutoshutdownNMT" flag.
>>
>> Please note that the following new stress tests are excluded with the 
>> JTREG @ignore tag:
>>
>> test/runtime/NMT/MallocSiteHashOverflow.java
>> test/runtime/NMT/MallocStressTest.java
>>
>> These tests can be run by using the jtreg override option 
>> "-ignore:run".  The new key "@key stress" was also added to these tests.
>>
>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8044140
>>     Webrev: 
>> http://cr.openjdk.java.net/~gtriantafill/bug_8044140/webrev.00/
>> <http://cr.openjdk.java.net/%7Egtriantafill/bug_8044140/webrev.00/>
>>     Testing: JTREG to exercise the added tests
>>
>> Thank you,
>>
>> George
>