RFR (S): 8044735: Print format/argument warnings

Mikael Vidstedt mikael.vidstedt at oracle.com
Wed Jun 4 01:24:06 UTC 2014


Vladimir/Chris - thanks for the reviews! I'll change to a print_cr (and 
remove the \n) before I commit.

Cheers,
Mikael

On 2014-06-03 17:08, Christian Thalinger wrote:
> Looks good.  The only thing you could change is using print_cr here:
> *!    tty->print("register window backtrace from_" INTPTR_FORMAT ":\n", p2i(sp)_);*
> *
> *
> On Jun 3, 2014, at 4:52 PM, Mikael Vidstedt 
> <mikael.vidstedt at oracle.com <mailto:mikael.vidstedt at oracle.com>> wrote:
>
>>
>> Please review this small change which addresses some (additional) 
>> printf format/argument mismatch warnings when compiling sparc files 
>> with gcc. A previous change (JDK-8044071) fixed it for the product 
>> version of Hotspot. This time around it's for warnings when compiling 
>> the debug version(s).
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8044735
>> Webrev: 
>> http://cr.openjdk.java.net/~mikael/webrevs/8044735/webrev.01/webrev/ 
>> <http://cr.openjdk.java.net/%7Emikael/webrevs/8044735/webrev.01/webrev/>
>>
>> Cheers,
>> Mikael
>>
>



More information about the hotspot-dev mailing list