RFR(M): 8044775: Improve usage of umbrella header atomic.inline.hpp.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jun 4 13:59:02 UTC 2014


Hi,

I would like to do another change cleaning up the includes of
.inline.hpp files from the os_cpu directories.

Please review and test this change.  I please need a sponsor.
http://cr.openjdk.java.net/~goetz/webrevs/8044775-atomInc/webrev.00/

This change improves the usage of the umbrella header atomic.inline.hpp.
It removes includes of this header in files where it's not needed,
and adds it in all .cpp and .inline.hpp files where a method of
Atomic declared 'inline' is used.

Also, the change moves some calls to such methods from .hpp files to
.inline.hpp files.  In case of ASSERT code it moves the calls
to .cpp files.

A row of headers still contain calls to inline methods of Atomic,
which I don't want to move as no appropriate .inline.hpp file is existing:

src/share/vm/compiler/compileBroker.hpp
src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp
src/share/vm/gc_implementation/g1/g1StringDedup.hpp
src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp
src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp
src/share/vm/memory/specialized_oop_closures.hpp
src/share/vm/oops/methodData.hpp
src/share/vm/runtime/safepoint.hpp
src/share/vm/services/lowMemoryDetector.hpp
src/share/vm/services/memTracker.hpp
src/share/vm/utilities/taskqueue.hpp

I compiled and tested this without precompiled headers on
linuxx86_64, linuxppc64, windowsx86_64, solaris_sparc64, solaris_sparc32, darwinx86_64, aixppc64
in opt, dbg and fastdbg versions.

Best regards,
  Goetz.


More information about the hotspot-dev mailing list