RFR (M): JDK-8043607: Add a GC id as a log decoration similar to PrintGCTimeStamps

[Thomas Schatzl]

Hi,

On Tue, 2014-06-10 at 14:37 +0200, Bengt Rutisson wrote:
> Hi Thomas,
> 
> Thanks for looking at this again!
> >
> > Regarding the test and possible backporting: the test currently assumes
> > that gc id printing is on by default. Wouldn't it be better to specify
> > +/-PrintGCId in the these tests to make sure it also works with
> > different default settings, and possibly one run checking default
> > settings?
> 
> Good point. I updated the test:
> http://cr.openjdk.java.net/~brutisso/8043607/webrev.06/test/gc/logging/TestGCId.java.html
> 
> Full new webrev (only the test has changed):
> http://cr.openjdk.java.net/~brutisso/8043607/webrev.06/
> 
> > You mentioned somewhere that you want to backport this change to 8u with
> > the default value of PrintGCid to be false (iirc) too.
> 
> Right. That is my plan. I will need to send out a separate review for 
> that since I will do a code change (the default value in globals.hpp), 
> so we can discuss the details during that review. With the new test the 
> only required change is to switch verify method for the default case.

Okay. Looks good to me.

Thomas