[9] RFR(XS): 8007987: ciConstantPoolCache::_keys should be array of 32bit int

[Coleen Phillimore]

> // ciConstantPoolCache
> //
> // The class caches indexed constant pool lookups.
> //
> // Usage note: this klass has nothing to do with ConstantPoolCache*.
Oh my gosh.

If _keys corresponds to constant pool indices then an int is enough to 
store the values, so this looks ok.  The ConstantPool length is a u2 but 
an int is better to future-proof this.

Coleen

On 6/26/14, 10:42 AM, Christian Thalinger wrote:
> Can you also have someone from the runtime team to take a quick look?  Sending to hotspot-dev instead.
>
> On Jun 26, 2014, at 5:55 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
>
>> Hi,
>>
>> please review the following small patch that changes the type of the keys stored in the array from intptr_t to int. This is sufficient to store the 2 byte constant pool indexes and conforms to the interface where int is used.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8007987
>> Webrev: http://cr.openjdk.java.net/~thartmann/8007987/webrev.00/
>> Testing: JPRT
>>
>> Thanks,
>> Tobias
>>