RFR(M/S): 8048169: Change 8037816 breaks HS build on PPC64 and CPP-Interpreter platforms

[David Holmes]

Hi Volker,

Two minor queries:

src/share/vm/interpreter/bytecodeInterpreter.cpp

+                    (int)(istate->bcp() - METHOD->code_base()),

Not clear that this is an int result - what type are the operands?

+  tty->print_cr("native_mirror: " INTPTR_FORMAT, (uintptr_t) 
this->_oop_temp);

uintptr_t or intptr_t ? (Yes I see the existing code has the same 
mismatch but I don't understand why.)

David
-----

On 28/06/2014 2:20 AM, Volker Simonis wrote:
> Hi,
>
> this is a follow-up for change "8037816: Fix for 8036122 breaks build
> with Xcode5/clang". It fixes the matching of format string parameter
> types to the actual argument types for the PPC64 and CPP-Interpreter
> files in the same way as 8037816 already did it for all the other
> files (so mainly insertions of 'p2i()' calls and some manual casts).
>
> http://cr.openjdk.java.net/~simonis/webrevs/8048169/
> https://bugs.openjdk.java.net/browse/JDK-8048169
>
> This change only touches PPC64 and the two CPP-Interpreter files
> src/share/vm/interpreter/bytecodeInterpreter.cpp and
> src/share/vm/interpreter/bytecodeInterpreterProfiling.hpp
>
> Please review and sponsor.
>
> Thank you and best regards,
> Volker
>