Bring Zero to llvm 3.4

Christian Thalinger christian.thalinger at oracle.com
Mon Mar 3 17:49:51 PST 2014


On Mar 3, 2014, at 5:54 AM, Mario Torre <neugens at redhat.com> wrote:

> On Mon, 2014-03-03 at 14:44 +0100, Mikael Gerdin wrote:
>> Hi Mario
>> 
>> On Monday 03 March 2014 14.28.33 Mario Torre wrote:
>>> On Mon, 2014-02-24 at 16:39 +0100, Mario Torre wrote:
>>>> On Mon, 2014-02-24 at 15:50 +0100, Mikael Gerdin wrote:
>>>>>> Interesting...
>>>>> 
>>>>> Indeed, what version of webrev are you using?
>>>>> The .changeset file created by recent versions of webrev has the
>>>>> advantage
>>>>> that it contains HG meta-information about which change the patch was
>>>>> created from.
>>>> 
>>>> I used the one that comes from within the JDK8 repository (cloned
>>>> sometime on Friday). I run webrev from a mercurial patch queue with the
>>>> applied patch, which should be visible as a committed changeset I think.
>>>> 
>>>> Cheers,
>>>> Mario
>>> 
>>> Hello Mikael,
>>> 
>>> The patch applied without modification on JDK9, here's the actual
>>> webrev:
>>> 
>>> http://cr.openjdk.java.net/~neugens/zero-2014-02-24/webrev.02/
>>> 
>>> If the patch is OK, can you please push it for me?
>> 
>> Unfortunately I'm not too familiar with the Zero/Shark code or the makefiles 
>> so I wouldn't feel comfortable putting my name as a reviewer on these changes. 
>> 
>> I'm sure that whoever reviews this change can push it for you as well.
>> 
>> /Mikael
> 
> Hi Mikael,
> 
> Thanks.
> 
> Anyone that can review it? Christian maybe?

Sure.  Looks good to me.

> 
> Cheers,
> Mario



More information about the hotspot-dev mailing list