8036702: Refactor os::safe_for_sender to work with non-Java threads
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Thu Mar 6 10:40:48 UTC 2014
Hi Erik,
I tested your change with the ppc64 port.
Could you please add the patch below to it, so that it does not break
the ppc64 build?
Thanks,
Goetz.
diff -r 5157d22ca82d src/cpu/ppc/vm/frame_ppc.cpp
--- a/src/cpu/ppc/vm/frame_ppc.cpp Thu Mar 06 11:32:05 2014 +0100
+++ b/src/cpu/ppc/vm/frame_ppc.cpp Thu Mar 06 11:39:43 2014 +0100
@@ -51,7 +51,7 @@
}
#endif // ASSERT
-bool frame::safe_for_sender(JavaThread *thread) {
+bool frame::safe_for_sender(Thread *thread) {
bool safe = false;
address cursp = (address)sp();
address curfp = (address)fp();
@@ -165,7 +165,7 @@
}
}
-bool frame::is_interpreted_frame_valid(JavaThread* thread) const {
+bool frame::is_interpreted_frame_valid(Thread* thread) const {
// Is there anything to do?
assert(is_interpreted_frame(), "Not an interpreted frame");
return true;
-----Original Message-----
From: hotspot-dev-bounces at openjdk.java.net [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Erik Helin
Sent: Donnerstag, 6. März 2014 09:35
To: hotspot-dev at openjdk.java.net
Subject: RFR: 8036702: Refactor os::safe_for_sender to work with non-Java threads
Hi all,
this patch changes the type of the parameter to the function
os::safe_for_sender from JavaThread* to Thread*. There is no code in
os::safe_for_sender that uses members that are specific to JavaThread.
This change is in preparation for JDK-8036699, which will do some stack
walking on non-Java thread and makes use of os::safe_for_sender for
non-Java threads.
Issue:
https://bugs.openjdk.java.net/browse/JDK-8036702
Webrev:
http://cr.openjdk.java.net/~ehelin/8036702/webrev.00/
Testing:
- JPRT
Thanks,
Erik
More information about the hotspot-dev
mailing list