RFR[9](S): 8036777: AIX: Adapt implementation after '6546236: Thread interrupt() of Thread.sleep() can be lost on Solaris..'

David Holmes david.holmes at oracle.com
Fri Mar 7 04:14:06 UTC 2014


Hi Volker,

I see Vladimir is already pushing this. It looks okay to me too.

Aside: I was surprised to see this:

  889 bool os::create_thread(Thread* thread, ThreadType thr_type, size_t 
stack_size) {
  890
  891   // We want the whole function to be synchronized.
  892   ThreadCritical cs;

Why do you need to serialize thread creation?

David
-----

On 7/03/2014 1:09 AM, Volker Simonis wrote:
> Hi,
>
> could you please review and push the following little AIX-only change
> which adapts the refactorings of  '6546236: Thread interrupt() of
> Thread.sleep() can be lost on Solaris..' to AIX:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8036777/
> https://bugs.openjdk.java.net/browse/JDK-8036777
>
> The change removes the implementations of os::sleep(), os::interrupt()
> and os::is_interrupted() from os_aix.cpp such that AIX now uses the
> implementations from os_posix.cpp like the other Unix platfroms and
> defines os::supports_monotonic_clock() in os_aix.inline.hpp.
>
> Thank you and best regards,
> Volker
>


More information about the hotspot-dev mailing list