RFR : JDK-8032045 : (m/l) Enable compiler and linker safety switches for debug builds

[Mike Duigou]

On Mar 12 2014, at 12:22 , Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

>> What are you referring to? A "normal" hotspot build starts with
>> make/Makefile. A developer on platform X may kick of a build using
>> make/X/Makefile (though we need to wean them off that). A top-level
>> configure-based build will also use make/Makefile.
> 
> DBG is defined in JDK make files only:
> 
> common//autoconf/generated-configure.sh:      VARIANT="DBG"
> common//autoconf/generated-configure.sh:      VARIANT="DBG"
> common//autoconf/hotspot-spec.gmk.in:# Legacy setting: OPT or DBG
> common//autoconf/jdk-options.m4:      VARIANT="DBG"
> common//autoconf/jdk-options.m4:      VARIANT="DBG"
> 
> But when we build Hotspot standalone we don't use or even have those files. So we should not check DBG in Hotspot's makefiles.

Do you mean that there are still builds of hotspot done without including hotspot-spec.gmk?

I'd certainly prefer to not have to accommodate that build configuration.

It appears that the spec.gmk variable DEBUG_LEVEL is more appropriate to consult than VARIANT and it is presumably included through hotspot-spec.gmk (which presumes hotspot-spec.gmk is included at all)

Mike