RFR (S): 8034034: JNI exc. pending in hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m

Calvin Cheung calvin.cheung at oracle.com
Mon Mar 17 18:13:34 UTC 2014


Please review this small fix for adding JNI exception check in 
MacosxDebuggerLocal.m.

This fix addresses the following warnings from our internal code 
analysis tool:

1)
Java exception thrown by 'GetFieldID(env, cls, "symbolicator", "J")' 
pending
  at call to 'GetFieldID' at line 132 of
  jdk8-b128/src/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m in function
  Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_init0
  JNI function 'GetFieldID' may throw an exception at line 131
  JNI function 'GetFieldID' is unsafe for a pending exception at line 132

2)
Java exception thrown by 'NewStringUTF(env, sym)' pending at call to
  'CallObjectMethod' at line 245 of
  jdk8-b128/src/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m in function
  Java_sun_jvm_hotspot_debugger_bsd_BsdDebuggerLocal_lookupByAddress0
  JNI function 'NewStringUTF' may throw an exception at line 245
  JNI function 'CallObjectMethod' is unsafe for a pending exception at 
line 245

3)
Java exception thrown by 'NewStringUTF(env, name)' pending at call to
  'CallObjectMethod' at line 756 of
  jdk8-b128/src/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m in function
  fillLoadObjects
  JNI function 'NewStringUTF' may throw an exception at line 756
  JNI function 'CallObjectMethod' is unsafe for a pending exception at 
line 756

4)
Java exception thrown by 'FindClass(env,
  "sun/jvm/hotspot/debugger/DebuggerException")' pending at call to 
'ThrowNew'
  at line 98 of 
jdk8-b128/src/hotspot/agent/src/os/bsd/MacosxDebuggerLocal.m in
  function throw_new_debugger_exception
  JNI function 'FindClass' may throw an exception at line 98
  JNI function 'ThrowNew' is unsafe for a pending exception at line 98


bug: https://bugs.openjdk.java.net/browse/JDK-8034034  (sorry, internal bug)

webrev: http://cr.openjdk.java.net/~ccheung/8034034/webrev/

test: JPRT

thanks,
Calvin



More information about the hotspot-dev mailing list