RFR (XXS): 8037962: metaspaceTracer.cpp misses a symbol

Mikael Gerdin mikael.gerdin at oracle.com
Thu Mar 20 15:10:51 UTC 2014


Erik,

On Thursday 20 March 2014 16.06.56 Erik Helin wrote:
> Hi all,
> 
> this small patch fixes an issue when compiling metaspaceTracer.cpp with
> OPENJDK=true and USE_PRECOMPILED_HEADER=0. The problem is that the
> symbol oopDesc::klass() is missing, this is fixed by including
> oops/oop.inline.hpp.
> 
> Thanks to Goetz Lindenmaier for finding this issue!
> 
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8037962/webrev.00/

Looks good.
We should really start linking with -Wl,-z,defs to make these build-time 
failures.

/Mikael

> 
> Testing:
> - Compiling with OPENJDK=true and USE_PRECOMPILED_HEADER=0 and then
>    running java -version
> 
> Thanks,
> Erik



More information about the hotspot-dev mailing list