RFR (XXS): 8037962: metaspaceTracer.cpp misses a symbol

Coleen Phillimore coleen.phillimore at oracle.com
Thu Mar 20 16:02:30 UTC 2014


Looks good.  Or we should have JPRT do a build without precompiled 
headers to prevent these.
Coleen

On 3/20/14 11:18 AM, Erik Helin wrote:
> Thomas and Mikael,
>
> thanks for the quick reviews!
>
> Erik
>
> On 03/20/2014 04:15 PM, Thomas Schatzl wrote:
>> Hi Erik,
>>
>> On Thursday 20 March 2014 16.06.56 Erik Helin wrote:
>>>   Hi all,
>>>
>>>   this small patch fixes an issue when compiling metaspaceTracer.cpp 
>>> with
>>>   OPENJDK=true and USE_PRECOMPILED_HEADER=0. The problem is that the
>>>   symbol oopDesc::klass() is missing, this is fixed by including
>>>   oops/oop.inline.hpp.
>>>
>>>   Thanks to Goetz Lindenmaier for finding this issue!
>>>
>>>   Webrev:
>>>   http://cr.openjdk.java.net/~ehelin/8037962/webrev.00/
>>
>> Looks good.
>>
>> Thanks,
>> Thomas
>>
>>



More information about the hotspot-dev mailing list