RFR(XS) : 8038240 : new WB API to get nmethod

John Rose john.r.rose at oracle.com
Thu Mar 27 00:54:48 UTC 2014


On Mar 25, 2014, at 3:03 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:

> Thanks for review, I support you suggestion, but as you said we are consistent w/ what we have, also we need this in 8u20, so we don't have enough time.
> I will file an RFE to change WB API and add version to the NMethod in accordance w/ your advice.
> 
> Do you agree w/ such approach? If yes, can I consider you as a Reviewer?

Yes, that is a good approach.  But, no, sorry: I didn't review your C code well enough to qualify as a Reviewer; I just looked at the API and traced the effect of the boolean.  It looks like you are good to go with Vladimir's review and Morris's and my input.

— John


More information about the hotspot-dev mailing list