RFR: 8038628: Remove unused Closure::abort()

Jon Masamitsu jon.masamitsu at oracle.com
Fri Mar 28 17:34:23 UTC 2014


On 3/28/2014 10:05 AM, Stefan Karlsson wrote:
> On 2014-03-28 17:49, Jon Masamitsu wrote:
>> Stefan,
>>
>> I could not tell from the CR why the use of Cosure::abort()
>> was removed.
>>
>>      }
>> -    if (cl->abort()) return cur;
>> -    // The check above must occur before the operation below, since an
>> -    // abort might invalidate the "size" operation.
>>      cur += obj->size();
>>
>> Can you explain a bit more?  Thanks.
>
> Closure::set_abort() is never called, so Closure::abort() always 
> returns false.

Thanks.

Reviewed.

Jon

>
> StefanK
>
>>
>> Jon
>>
>>
>> On 3/28/2014 6:13 AM, Stefan Karlsson wrote:
>>> Please, review this small patch to remove Closure::abort().
>>>
>>> webrev: http://cr.openjdk.java.net/~stefank/8038628/webrev.00/
>>> RFE: https://bugs.openjdk.java.net/browse/JDK-8038628
>>>
>>> thanks,
>>> StefanK
>>
>



More information about the hotspot-dev mailing list