RFR(S): 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods

David Holmes david.holmes at oracle.com
Thu May 1 06:25:05 UTC 2014


Hi Zhengyu,

On 30/04/2014 10:47 PM, Zhengyu Gu wrote:
> This is more of code cleanup. Instead of duplicating similar code all
> over subclasses of NamedThread, NamedThread should implements
> print_on(outputStream* str) and its subclasses should only set "name" to
> use default the implementation.
>
> Webrev: http://cr.openjdk.java.net/~zgu/6885993/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-6885993

I agree with Christian that print_on should probably not be inlined in 
thread.hpp

> Tests:
>    - JPRT
>    - Ran a Java program on Linux x64, do "CTRL-\" to dump Java stacks,
> make sure the output remains unchange.

Note that none of the above tests printing for the GC threads. Of course 
if it works for one NamedThread then it should work for them all :)

The actual Java threads are unaffected by this change.

Thanks,
David

> Thanks,
>
> -Zhengyu


More information about the hotspot-dev mailing list