RFR(S): 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods

Zhengyu Gu zhengyu.gu at oracle.com
Thu May 1 11:57:46 UTC 2014


Thanks for the review.

On 4/30/2014 6:58 PM, Christian Thalinger wrote:
> I’d prefer to have the method body of:
> *+   virtual void print_on(outputStream* st) const {*
> in the .cpp file.
Will move to .cpp file.

-Zhengyu

>
> Otherwise this is very nice and looks good.
>
> On Apr 30, 2014, at 2:47 AM, Zhengyu Gu <zhengyu.gu at oracle.com 
> <mailto:zhengyu.gu at oracle.com>> wrote:
>
>> This is more of code cleanup. Instead of duplicating similar code all 
>> over subclasses of NamedThread, NamedThread should implements 
>> print_on(outputStream* str) and its subclasses should only set "name" 
>> to use default the implementation.
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/6885993/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ezgu/6885993/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6885993
>>
>> Tests:
>>  - JPRT
>>  - Ran a Java program on Linux x64, do "CTRL-\" to dump Java stacks, 
>> make sure the output remains unchange.
>>
>> Thanks,
>>
>> -Zhengyu
>



More information about the hotspot-dev mailing list