RFR (M): 8042195: Introduce umbrella header orderAccess.inline.hpp.
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Fri May 2 12:23:41 UTC 2014
Hi,
Please review and test this change. I please need a sponsor.
http://cr.openjdk.java.net/~goetz/webrevs/8042195-oaIncl/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8042195
This change introduces an umbrella header for orderAccess_<os>_<cpu>.inline.hpp
files: runtime/orderAccess.inline.hpp. This follows the scheme applied to
atomic.inline.hpp.
Further this change adds includes of orderAccess.inline.hpp in all .cpp
and .inline.hpp files where a method of OrderAccess declared 'inline' is
called.
Finally it moves methods calling inline methods of OrderAccess from
g1CollectedHeap.hpp and thread.hpp to the corresponding .inline.hpp
files and adds the necessary includes in files using the moved
functions.
Still a lot of calls to inline methods of OrderAccess in .hpp
files arn't preceded by an according include. But for these
files an appropriate .inline.hpp file is missing:
src/cpu/ppc/vm/javaFrameAnchor_ppc.hpp
src/cpu/sparc/vm/javaFrameAnchor_sparc.hpp
src/share/vm/classfile/classLoader.hpp
src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp
src/share/vm/memory/cardTableModRefBS.hpp
src/share/vm/oops/constantPool.hpp
src/share/vm/oops/cpCache.hpp
src/share/vm/oops/instanceKlass.hpp
src/share/vm/oops/method.hpp
src/share/vm/oops/methodData.hpp
src/share/vm/oops/typeArrayOop.hpp
src/share/vm/runtime/interfaceSupport.hpp
src/share/vm/utilities/array.hpp
src/share/vm/utilities/taskqueue.hpp
Testing:
I ran builds on linuxx86_64, sun_32, sun_64, mac, windowsx86_64, linuxppc64 and aix;
dbg, fastdbg and product without precompiled headers.
Thanks and best regards,
Goetz
More information about the hotspot-dev
mailing list