RFR (M): 8042195: Introduce umbrella header orderAccess.inline.hpp.

[Lindenmaier, Goetz]

Hi Vladimir, 

I fixed what you proposed except for precompiled.hpp:
There always the .hpp and .inline.hpp are mentioned, so I'd like to 
do it for this file the same way.

Webrev is updated: 
http://cr.openjdk.java.net/~goetz/webrevs/8042195-oaIncl/webrev.00/

No problem with closed sources, there is no hurry with this one.

Thanks and best regards,
  Goetz


Vladimir, sorry you get this twice, I forgot the mailing list first.

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
Sent: Friday, May 02, 2014 9:36 PM
To: hotspot-dev at openjdk.java.net
Subject: Re: RFR (M): 8042195: Introduce umbrella header orderAccess.inline.hpp.

Hi Goetz,

In general it is good but sponsor from Oracle have to check and fix our 
closed sources too.

I see in metaspace.cpp, precompiled.hpp you kept orderAccess.hpp include 
which is not needed:

  # include "runtime/orderAccess.hpp"
+# include "runtime/orderAccess.inline.hpp"

Typo in oops/klass.hpp?:

-  // Ordered list of all primary supertypes
+  // Orderd list of all primary supertypes

In javaFrameAnchor.hpp preserve original order - globalDefinitions.hpp 
first.

Thanks,
Vladimir

On 5/2/14 5:23 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> Please review and test this change.  I please need a sponsor.
> http://cr.openjdk.java.net/~goetz/webrevs/8042195-oaIncl/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8042195
>
> This change introduces an umbrella header for orderAccess_<os>_<cpu>.inline.hpp
> files: runtime/orderAccess.inline.hpp. This follows the scheme applied to
> atomic.inline.hpp.
>
> Further this change adds includes of orderAccess.inline.hpp in all .cpp
> and .inline.hpp files where a method of OrderAccess declared 'inline' is
> called.
>
> Finally it moves methods calling inline methods of OrderAccess from
> g1CollectedHeap.hpp and thread.hpp to the corresponding .inline.hpp
> files and adds the necessary includes in files using the moved
> functions.
>
> Still a lot of calls to inline methods of OrderAccess in .hpp
> files arn't preceded by an according include.  But for these
> files an appropriate .inline.hpp file is missing:
>
> src/cpu/ppc/vm/javaFrameAnchor_ppc.hpp
> src/cpu/sparc/vm/javaFrameAnchor_sparc.hpp
> src/share/vm/classfile/classLoader.hpp
> src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp
> src/share/vm/memory/cardTableModRefBS.hpp
> src/share/vm/oops/constantPool.hpp
> src/share/vm/oops/cpCache.hpp
> src/share/vm/oops/instanceKlass.hpp
> src/share/vm/oops/method.hpp
> src/share/vm/oops/methodData.hpp
> src/share/vm/oops/typeArrayOop.hpp
> src/share/vm/runtime/interfaceSupport.hpp
> src/share/vm/utilities/array.hpp
> src/share/vm/utilities/taskqueue.hpp
>
> Testing:
> I ran builds on linuxx86_64, sun_32, sun_64, mac, windowsx86_64, linuxppc64 and aix;
> dbg, fastdbg and product without precompiled headers.
>
> Thanks and best regards,
>    Goetz
>