RFR(M): 8042309: Some bugfixes for the ppc64 port.

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue May 6 18:55:13 UTC 2014


Looks fine to me. Only minor issues in ppc.ad:
New vtable_index is not used.
It is strange to see predicate(false) in expanded instructions.

Thanks,
Vladimir

On 5/6/14 3:17 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> please review this change.  I also please need a sponsor.
> It should go to jdk8u20 at some point.  It only touches files
> needed for the ppc64 port.
> http://cr.openjdk.java.net/~goetz/webrevs/8042309/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8042309
>
> This change fixes a few bugs in the ppc64 port:
>
> * Expand of max/min nodes in .ad file relied on 64-bit sign extend
>    but placed the values in 32-bit registers.  After SpillCopies
>    the upper bits were lost.
> * Expand of decodeNKlass used wrong node.
> * Implement missing support for method handles in generate_throw_exception.
> * Some small optimizations and cleanups.
>
> Thanks and best regards,
>    Goetz.
>


More information about the hotspot-dev mailing list