Update: RFR(XS) 8041415: remove port.{cpp,hpp} files

Zhengyu Gu zhengyu.gu at oracle.com
Wed May 7 13:00:06 UTC 2014


Thanks for the review.

Vladimir Kozlov also reviewed.

-Zhengyu

On 5/6/2014 4:47 PM, Coleen Phillimore wrote:
>
> This looks good to me, but I think you need someone from the compiler 
> group to review also because it's all in the compiler code.
>
> Thanks!
> Coleen
>
> On 5/6/14, 4:33 PM, Zhengyu Gu wrote:
>> Sorry, missed this one.
>>
>> One more try: http://cr.openjdk.java.net/~zgu/8041415/webrev.02/ 
>> <http://cr.openjdk.java.net/%7Ezgu/8041415/webrev.02/>
>>
>> Thanks,
>>
>> -Zhengyu
>>
>> On 5/6/2014 3:50 PM, Vladimir Kozlov wrote:
>>> output.cpp change still use (uint) -1
>>>
>>> Vladimir
>>>
>>> On 5/6/14 12:44 PM, Zhengyu Gu wrote:
>>>> Hi,
>>>>
>>>> I updated the webrev to reflect Lois' change and Vladimir's comments.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8041415
>>>> Webrev: http://cr.openjdk.java.net/~zgu/8041415/webrev.01/
>>>> <http://cr.openjdk.java.net/%7Ezgu/8041415/webrev.01/>
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>
>>>> On 5/5/2014 4:36 PM, Vladimir Kozlov wrote:
>>>>> CC to compiler alias since you changing our code.
>>>>>
>>>>> Copyright year change should be 2014.
>>>>>
>>>>> FileBuffRegion removal is done under separate bug 8041620 by Lois
>>>>> Foltan, the review was sent today today.
>>>>>
>>>>> domgraph.cpp, output.cpp: use max_juint instead of (uint) -1.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 5/5/14 1:21 PM, Zhengyu Gu wrote:
>>>>>> This is a code cleanup based on attached patch from Christian 
>>>>>> Thalinger.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8041415
>>>>>> Webrev:
>>>>>
>>>>>  http://cr.openjdk.java.net/~zgu/8041415/webrev.00/
>>>>>
>>>>>>
>>>>>> Test:
>>>>>>    JPRT
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>
>>
>



More information about the hotspot-dev mailing list