[9] RFR(L): 8037816 : Fix for 8036122 breaks build with Xcode5/clang

[Vladimir Kozlov]

On 5/7/14 5:59 PM, David Chase wrote:
>
> On 2014-05-07, at 6:38 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> I see several cases of new print_raw_cr(). Why not print_cr("%s", msg)? It is in ciInstanceKlass.cpp, javaClasses.cpp, codeBlob.cpp, compilerOracle.cpp, g1CollectedHeap.cpp, psPromotionManager.cpp, metaspaceShared.cpp, constMethod.cpp, constantPool.cpp, cpCache.cpp, instanceKlass.cpp, method.cpp, loopnode.cpp, jniCheck.cpp, java.cpp, os.cpp, sweeper.cpp, thread.cpp, attachListener.cpp, diagnosticCommand.cpp, nmtDCmd.cpp, ostream.cpp, vmError.cpp.
>
> Thank you, I missed print_raw_cr (because I was so thrilled at how efficiently I dispatched print_raw).
>
>> In ciEnv.cpp  it can be merged with previous line:
>>
>>   tty->print("# Compiler replay data is saved as: %s", buffer);
>>   tty->print("# Compiler inline data is saved as: %s", buffer);

Correction: the above should be print_cr(). The original code was:

      tty->print("# Compiler replay data is saved as: ");
      tty->print_cr(buffer);

Thanks,
Vladimir

>>
>> In ageTable.cpp why you changed type of 'age' from uint to uintx? The used format for it is "%3u".
>
> I am not sure; I will check.  It appeared from the repeated use of UINTX_FORMAT that uintx was intended,
> so I changed it.  I can (will, unless someone objects) change that back to uint with consistent formats.

It is printed only in one place and you kept %3u for it:

!  gclog_or_tty->print_cr("- age %3u: " SIZE_FORMAT_W(10) " bytes, " 
SIZE_FORMAT_W(10) " total",
                                  age,    sizes[age]*oopSize, 
total*oopSize);

Note, age <= table_size and table_size is 16.

Vladimir

>
>> Did you changes some spacing in generateOopMap.cpp? I see only Copyright year update.
>
> This is probably an artifact of incorporating Henry's better use of annotations, which then caused
> the backout of some earlier changes.  I wasn't supposed to have touched any copyrights yet; that
> I have an automated script to handle, along with trailing spaces.
>
>> In memnode.cpp use INTX_FORMAT instead of %" PRIdPTR.
>
> Will do.
>
> Thanks very much for your attention to detail on this.
>
> David
>