[9] RFR(L): 8037816 : Fix for 8036122 breaks build with Xcode5/clang

[Mike Duigou]

On May 8 2014, at 14:08 , David Chase <david.r.chase at oracle.com> wrote:
> 
> 1) investigate definition of PTR_FORMAT as some form of %p, together with a clean separation
> of PTR_FORMAT and INTPTR_FORMAT in formatting (we should be nearly there already).
> Do NOT do a wholesale replace of INTPTR_FORMAT.

This is something we should definitely move towards. Output form of pointers issue in the jdk repo as well. (Still many %x for pointers). Code or tests which depend upon something other than %p format should be changed/fixed.

> 4) incremental removal of PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC
> (This should follow resolution of follow-on bug (1), so that the PTR_FORMAT option is available).

The PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC usage seemed like a big hammer on first reading but it is much better than -Wno-error=format-literal and I am glad to see that you have a plan for being able to reduce it's use. Is there any way we can ensure that it happens and doesn't end up as maintenance rot?

Mike