RFR: 8011397: JTREG needs to copy additional WhiteBox class file to JTwork/scratch/sun/hotspot

[David Holmes]

To be reviewed this needs a webrev on cr.openjdk.java.net

Thanks,
David

On 9/05/2014 1:28 AM, Igor Ignatyev wrote:
> // cc'ing hotspot-dev instaed of compiler, runtime and gc lists.
>
>
> On 05/08/2014 07:09 PM, Filipp Zhinkin wrote:
>> Andrey,
>>
>> I've CC'ed compiler and runtime mailing list, because you're changes
>> affect test for other components as too.
>>
>> I don't like your solution (but I'm not a reviewer, so treat my words
>> just as suggestion),
>> because we'll have to write more meta information for each test and it
>> is very easy to
>> forget to install WhiteBoxPermission if you don't test your test with
>> some security manager.
>>
>>  From my point of view, it will be better to extend ClassFileInstaller
>> so it will copy not only
>> a class whose name was passed as an arguments, but also all inner
>> classes of that class.
>> And if someone want copy only specified class without inner classes,
>> then some option
>> could be added to ClassFileInstaller to force such behaviour.
>>
>> Thanks,
>> Filipp.
>>
>> On 05/08/2014 04:47 PM, Andrey Zakharov wrote:
>>> Hi!
>>> Suggesting patch with fixes for
>>> https://bugs.openjdk.java.net/browse/JDK-8011397
>>>
>>> webrev:
>>> https://bugs.openjdk.java.net/secure/attachment/20275/8011397.tgz
>>> patch:
>>> https://bugs.openjdk.java.net/secure/attachment/20274/8011397.WhiteBoxPermission
>>>
>>>
>>>
>>>
>>> Thanks.
>>