RFR(S): 8042471 - Unable to build JDK 9 Hotspot within VS2010

[Christian Tornqvist]

Hi Staffan,

This is the fix for the first problem I hit:

Invalid command line switch for "CL.exe". The value
[HOTSPOT_RELEASE_VERSION=""1.9.0"""] contains an odd number of double-quote
characters. Only even numbers of literal double-quote characters are
acceptable to command line tools.

I can't say for sure but I think this is because of the quotations of
JRE_RELEASE_VERSION earlier so we somehow end up with unmatched quotes. The
change
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/2fd040528b2a introduced
this assignment. 

Since JRE_RELEASE_VERSION is already quoted on L89 / L91 I think it's enough
to just assign the value directly.

Thanks,
Christian

-----Original Message-----
From: Staffan Larsen [mailto:staffan.larsen at oracle.com] 
Sent: Friday, May 9, 2014 8:02 AM
To: Christian Tornqvist
Cc: hotspot-dev at openjdk.java.net Developers
Subject: Re: RFR(S): 8042471 - Unable to build JDK 9 Hotspot within VS2010

L96: HOTSPOT_RELEASE_VERSION=$(JRE_RELEASE_VERSION)

Why do all other assignments have lots of "\\\" around the value, but not
this one?

Looks good otherwise,
/Staffan

On 8 maj 2014, at 23:38, Christian Tornqvist
<christian.tornqvist at oracle.com> wrote:

> Hi everyone,
> 
> 
> 
> Small fix for issues with generation of project files for Visual Studio.
> Recent changes in how Hotspot versioning works broke the Visual Studio 
> build, the fix has been tested by me, Harold and Lois.
> 
> 
> 
> Webrev can be found at:
> 
> http://cr.openjdk.java.net/~ctornqvi/webrev/8042471/webrev.00/
> 
> 
> 
> Bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8042471
> 
> 
> 
> Thanks,
> 
> Christian
>