[9] RFR(L): 8037816 : Fix for 8036122 breaks build with Xcode5/clang

Stefan Karlsson stefan.karlsson at oracle.com
Fri May 9 15:21:11 UTC 2014


On 2014-05-09 17:14, David Chase wrote:
> Revised patch, after some offline discussion with Stefan:
>
> webrev: http://cr.openjdk.java.net/~drchase/8037816/webrev-9.05-09b/
>
> interdiff from previous: http://cr.openjdk.java.net/~drchase/8037816/9.0508b-0509b.interdiff
>
> (I recommend the interdiff)
>
> The difference is that in the GC code, where PTR_FORMAT and INTPTR_FORMAT have
> been used to express an intention (even though C++ compilers and standards conspire
> against this) to preserve that intention.  There's likely to be some future change, but it is
> important to preserve the intention till that change.
>
> There was no change to the 8u patch (i.e., the use of PTR_FORMAT in the GC code was
> preserved there already; I'm going to check the rest of the 8u patch to see if the INTPTR_FORMAT
> introductions there conform to goals for the other parts of the code).
>
> Testing so far has been minimal, but this is an extremely lightweight patch, and PTR_FORMAT
> and INTPTR_FORMAT currently have identical macro expansion.  I thought I would get this up
> for discussion/review first, then get the testing started.

Thanks for being accommodating with this!

StefanK

>
> David
>



More information about the hotspot-dev mailing list