Wish to push fix for 8037816 into main

David Chase david.r.chase at oracle.com
Sat May 10 11:52:42 UTC 2014


I think so.

It went here: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/53a41e7cbe05
(With its corresponding closed change, where I goofed and left you off the list of reviewers, sorry.)

David

On 2014-05-10, at 7:27 AM, David Holmes <david.holmes at oracle.com> wrote:

> On 10/05/2014 6:02 AM, Alejandro E Murillo wrote:
>> No, this is the one:
>> 
>> http://hg.openjdk.java.net/jdk9/hs/hotspot
> 
> So to be clear, this is being pushed into hs/hotspot so that it will be pulled down into the hotspot group repos, but it won't get pushed up to jdk9/dev until the next snapshot - right ?
> 
> Thanks,
> David
> 
>> Alejandro
>> 
>> On 5/9/2014 2:01 PM, David Chase wrote:
>>> Alejandro, which repository do I push to?
>>> 
>>> http://hg.openjdk.java.net/jdk9/dev/hotspot?
>>> 
>>> David
>>> 
>>> 
>>> On 2014-05-09, at 2:44 PM, Alejandro E Murillo
>>> <alejandro.murillo at oracle.com> wrote:
>>> 
>>>> I just took the weekly snapshot,
>>>> so now is a good timing to do that, as then it will be picked up
>>>> by all the group repos when they synch down
>>>> 
>>>> Alejandro
>>>> 
>>>> On 5/9/2014 12:37 PM, Vladimir Kozlov wrote:
>>>>> Good.
>>>>> 
>>>>> We want to push it into main jdk9/hs/hotspot and let groups to pull
>>>>> it into their repos. It will allow to test it in all our
>>>>> configurations.
>>>>> 
>>>>> Thanks,
>>>>> Vladimir
>>>>> 
>>>>> On 5/9/14 11:28 AM, David Chase wrote:
>>>>>> Here's the webrev, minus automated copyright insertions:
>>>>>> 
>>>>>> http://cr.openjdk.java.net/~drchase/8037816/webrev-9.05-09b/
>>>>>> 
>>>>>> It's large, it touches a lot, and I can build on Mavericks
>>>>>> (with the addition of a one-time fix to header files, not sure
>>>>>> how to automate that).  It sets attributes to turn on format checking,
>>>>>> and formats are mostly/often checked -- there are disabling macros
>>>>>> for problematic files, but I fixed all the true stinkers by hand.
>>>>>> 
>>>>>> I have thumbs up from Vladimir Kozlov and Stefan Karlsson.
>>>>>> 
>>>>>> And this gets it in everyone's face sooner, because we might
>>>>>> want to do this to 8u20 just so that backports won't be too horrible.
>>>>>> (A backport patch is already prepared, being further studied for
>>>>>> mistakes, and has been JPRT-tested.)
>>>>>> 
>>>>>> Opinions?
>>>>>> 
>>>>>> David
>>>>>> 
>>>> --
>>>> Alejandro
>>>> 
>> 



More information about the hotspot-dev mailing list