RFR(M): 8042737 : Introduce umbrella header prefetch.inline.hpp

Christian Thalinger christian.thalinger at oracle.com
Thu May 15 15:13:47 UTC 2014


Looks good to me.  I thought that prefetch is used more often but apparently not.

On May 15, 2014, at 1:16 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:

> Hi,
> 
> This change introduces an umbrella header for prefetch_<os>_<cpu>.inline.hpp
> files: runtime/prefetch.inline.hpp as proposed in
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-April/013702.html
> This follows the scheme applied to atomic.inline.hpp.
> 
> Further this change adds includes of prefetch.inline.hpp in all .cpp
> and .inline.hpp files where a method of Prefetch declared 'inline' is
> called.
> 
> Finally it moves macros calling inline methods of Prefetch from
> space.hpp to the corresponding .inline.hpp file and adds the necessary
> includes in files using the moved macros.
> 
> Please review and test this change.  I please need a sponsor.
> http://cr.openjdk.java.net/~goetz/webrevs/8042737-prefIncl/webrev.00/
> 
> Thanks and best regards,
>  Goetz.



More information about the hotspot-dev mailing list