RFR (XS): 8044071: Print format/argument warnings
Mikael Vidstedt
mikael.vidstedt at oracle.com
Tue May 27 22:22:47 UTC 2014
Please review the below change which addresses a number of print
format/argument mismatches when compiling linux/sparc using gcc.
Bug: https://bugs.openjdk.java.net/browse/JDK-8044071
Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8044071/webrev.00/webrev/
Most of these are straightforward changes to INTPTR_FORMAT & adding p2i.
A couple of changes worth bringing up:
* nativeInst_sparc.cpp
I changed the format of the offset in mov related prints (two
occurrences) to %d, since it's really a signed decimal int. This will
hopefully reduce confusion when the offset is negative, where previously
it would have looked like a relatively large positive offset.
* macroAssembler_sparc.cpp
The new code is in line with other similar patterns in the same file,
but the ugly cast should IMHO really be rewritten to cast through a
union. RFE?
Cheers,
Mikael
More information about the hotspot-dev
mailing list