8061969 - [TESTBUG] MallocSiteHashOverflow.java should be enabled for 32-bit platforms

[Christian Tornqvist]

Hi George,

Some comments:

src/share/vm/prims/whitebox.cpp

L362, you should assert on hash_size rather than calling hash_buckets() again.

test/runtime/NMT/MallocSiteHashOverflow.java

L41 and L52 are both getting the WhiteBox instance, I'd remove L41 and move MAX_HASH_SIZE into main instead.


Otherwise this looks good, thanks for doing this.

Thanks,
Christian

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of George Triantafillou
Sent: Wednesday, November 5, 2014 10:00 AM
To: hotspot-dev at openjdk.java.net
Subject: RFR: 8061969 - [TESTBUG] MallocSiteHashOverflow.java should be enabled for 32-bit platforms

Please review this fix for JDK-8061969.  The test was modified to verify the fix for JDK-8058251, but since another intermittent issue was uncovered during testing (JDK-8062870), this test will retain the "@ignore" jtreg tag until the new issue is fixed.  Additionally, the "@requires" tag was used to ensure that the test only runs on 32-bit platforms.

Bug: https://bugs.openjdk.java.net/browse/JDK-8061969
Webrev: http://cr.openjdk.java.net/~gtriantafill/8061969/webrev/
<http://cr.openjdk.java.net/%7Egtriantafill/8061969/webrev/>

The fix was tested locally on Linux with jtreg and the JPRT hotspot testset.

-George