RFR(XS): 8064786: Fix debug build after 8062808: Turn on the -Wreturn-type warning

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 13 11:52:46 UTC 2014


Hi,

On Thu, 2014-11-13 at 11:34 +0100, Stefan Karlsson wrote:
> On 2014-11-13 11:20, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > please review, test and sponsor this tiny change.  It fixes the debug build in the gc repository.
> > https://bugs.openjdk.java.net/browse/JDK-8064786
> > http://cr.openjdk.java.net/~goetz/webrevs/8064786-warnRet/webrev.00/
> 
> Looks good. Thanks for fixing. Another approach would be to just remove 
> the ShouldNotReachHere() lines.
> 
> I'll push when we get another review.

Looks good to me.

Thomas



More information about the hotspot-dev mailing list