RFR(XS): 8064786: Fix debug build after 8062808: Turn on the -Wreturn-type warning

[Daniel D. Daugherty]

On 11/13/14 4:59 AM, David Holmes wrote:
> On 13/11/2014 9:55 PM, Lindenmaier, Goetz wrote:
>> Maybe you don't do a debug build.  Fastdbg and opt pass.
>
> Ah - no we don't do debug, just product and fastdebug.
>
> <sigh> too many variations. But I'm concerned because this suggests 
> there are more differences between debug and fastdebug than just 
> optimization levels (which I thought was the difference).

There are a few places where a debug build has more verification code
because running that verification code takes a long time. I remember
running into this in the StringTable stuff that I played with more
than a year ago...

Dan


>
> Thanks,
> David
>
>> I verified that it's not my old compiler, gcc 4.3.4 fails, too.
>>
>> Best regards,
>>    Goetz
>>
>> -----Original Message-----
>> From: David Holmes [mailto:david.holmes at oracle.com]
>> Sent: Donnerstag, 13. November 2014 12:54
>> To: Stefan Karlsson; Lindenmaier, Goetz; hotspot-dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8064786: Fix debug build after 8062808: Turn on 
>> the -Wreturn-type warning
>>
>> On 13/11/2014 8:34 PM, Stefan Karlsson wrote:
>>> On 2014-11-13 11:20, Lindenmaier, Goetz wrote:
>>>> Hi,
>>>>
>>>> please review, test and sponsor this tiny change.  It fixes the debug
>>>> build in the gc repository.
>>>> https://bugs.openjdk.java.net/browse/JDK-8064786
>>>> http://cr.openjdk.java.net/~goetz/webrevs/8064786-warnRet/webrev.00/
>>>
>>> Looks good. Thanks for fixing. Another approach would be to just remove
>>> the ShouldNotReachHere() lines.
>>>
>>> I'll push when we get another review.
>>
>> Reviewed.
>>
>> But I'm concerned as to how this was not detected with the original fix.
>> I assume we don't build with a compiler that complains about this code?
>>
>> Thanks,
>> David
>>
>>> thanks,
>>> StefanK
>>>
>>>>
>>>> Best regards,
>>>>     Goetz.
>>>