Review request for JDK-8064571: java/lang/instrument/IsModifiableClassAgent.java: assert(length > 0) failed: should only be called if table is present

Eric McCorkle eric.mccorkle at oracle.com
Fri Nov 14 13:56:30 UTC 2014


Actually, I realized the comparison in the assert is tautologically
false.  Therefore, I removed the assert altogether.  Please re-approve.

On 11/13/14 16:09, Coleen Phillimore wrote:
> 
> Looks good.  Thanks for running the java/lang/instrument tests.
> 
> Coleen
> 
> On 11/13/14, 4:04 PM, Eric McCorkle wrote:
>> Hello,
>>
>> Please review this simple fix for a JDK test failure that was introduced
>> by the change for JDK-8058313.  A condition for an assertion was left as
>> ">", when it should have been changed to ">=".
>>
>> Note that this only occurs in artificial test cases; javac does not
>> produce classfiles with zero-length MethodParameters attributes.
>>
>> The webrev is here:
>> http://cr.openjdk.java.net/~emc/8064571/
>>
>> The bug report is here:
>> https://bugs.openjdk.java.net/browse/JDK-8064571
> 


More information about the hotspot-dev mailing list