Review request for JDK-8064571: java/lang/instrument/IsModifiableClassAgent.java: assert(length > 0) failed: should only be called if table is present

[Jiangli Zhou]

Hi Eric,

Looks okay to me also.

Thanks,
Jiangli

On 11/14/2014 08:15 AM, Coleen Phillimore wrote:
>
> Okay, yes this is fine.   We need Jiangli to review it too.
> Coleen
>
> On 11/14/14, 8:56 AM, Eric McCorkle wrote:
>> Actually, I realized the comparison in the assert is tautologically
>> false.  Therefore, I removed the assert altogether.  Please re-approve.
>>
>> On 11/13/14 16:09, Coleen Phillimore wrote:
>>> Looks good.  Thanks for running the java/lang/instrument tests.
>>>
>>> Coleen
>>>
>>> On 11/13/14, 4:04 PM, Eric McCorkle wrote:
>>>> Hello,
>>>>
>>>> Please review this simple fix for a JDK test failure that was 
>>>> introduced
>>>> by the change for JDK-8058313.  A condition for an assertion was 
>>>> left as
>>>> ">", when it should have been changed to ">=".
>>>>
>>>> Note that this only occurs in artificial test cases; javac does not
>>>> produce classfiles with zero-length MethodParameters attributes.
>>>>
>>>> The webrev is here:
>>>> http://cr.openjdk.java.net/~emc/8064571/
>>>>
>>>> The bug report is here:
>>>> https://bugs.openjdk.java.net/browse/JDK-8064571
>