RFR (L): 8062370: Various minor code improvements

David Holmes david.holmes at oracle.com
Tue Nov 18 01:37:05 UTC 2014


For the record looks good to me.

Thanks,
David

On 14/11/2014 7:59 PM, Thomas Stüfe wrote:
> Hi David,
>
> thanks for looking. See here the corrected webrev:
>
> http://cr.openjdk.java.net/~simonis/webrevs/8064779/
>
> for this new bug report:
>
> https://bugs.openjdk.java.net/browse/JDK-8064779
>
> Best Regards, Thomas
>
>
> On Thu, Nov 13, 2014 at 4:03 AM, David Holmes <david.holmes at oracle.com
> <mailto:david.holmes at oracle.com>> wrote:
>
>     Hi Thomas,
>
>     On 12/11/2014 8:31 PM, Thomas Stüfe wrote:
>
>         Hi,
>
>         could you please review this little addition? (added comments for
>         jio_snprintf)
>
>         http://cr.openjdk.java.net/~__simonis/webrevs/8062370/
>         <http://cr.openjdk.java.net/~simonis/webrevs/8062370/>
>
>
>     A new bug is needed for these changes.
>
>     As people rarely look at the header file when reading the code could
>     you augment the last line of the comment in jvm.cpp from:
>
>     +   // return always -1.
>
>     to
>
>     +   // always return -1, and perform null termination.
>
>     Thanks,
>     David
>


More information about the hotspot-dev mailing list