(9) RFR: 8064815 Zero+PPC64: Stack overflow when running Maven

[Vladimir Kozlov]

Looks good.

Thanks,
Vladimir

On 11/18/14 3:05 AM, Severin Gehwolf wrote:
> Hi Volker, Vladimir,
>
> On Tue, 2014-11-18 at 11:21 +0100, Volker Simonis wrote:
> [...]
>>>> I think an assertion would be good.
>>>
>>> Sure. Updated webrev coming soon.
>>>
>>>> (but 'abi_available' should be an
>>>> 'int' because 'ssize_t' is only specified to hold values  from -1 to
>>>> SSIZE_MAX).
>>>
>>> OK, thanks! In that case I think it's safer to also change back the
>>> return type of abi_stack_available(). ssize_t worked since it's defined
>>> as signed int on linux.
>>>
>>
>> I don't like ssize_t because of it's unclear semantics. I understand
>> that it happens to work on Linux because it's defined as a signed int
>> there. But then why not use an int in the first place? So I'd prefer
>> if you'd use an int.
>
> Agreed. Changed it back to use an int.
>
> On Mon, 2014-11-17 at 09:54 -0800, Vladimir Kozlov wrote:
>> I mean next guarantee:
>>
>>     guarantee(Thread::current() == thread, "should run in the same
>> thread");
>>
>> otherwise 'thread->stack_base() - (address) &stack_used' will give
>> wrong result if threads are different.
>
> Thanks for the clarification, Vladimir! I've added this guarantee.
>
> Updated webrev:
> https://jerboaa.fedorapeople.org/bugs/openjdk/JDK-8064815/webrev.1/
>
> Thanks again for the reviews!
>
> Cheers,
> Severin
>