RFR 8042235: redefining method used by multiple MethodHandles crashes VM

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Nov 18 19:58:37 UTC 2014


No problem, Coleen.

Thanks!
Serguei

On 11/18/14 7:52 AM, Coleen Phillimore wrote:
>
> Thank you Serguei.  I forgot to mention in the RFR that you actually 
> diagnosed the problem, and this fix is based on the one you provided 
> in the bug.
>
> Thanks!
> Coleen
>
> On 11/17/14, 7:44 PM, serguei.spitsyn at oracle.com wrote:
>> Coleen,
>>
>> The fix look good.
>> Thank you for taking care about this!
>>
>> Thanks,
>> Serguei
>>
>> On 11/17/14 2:49 PM, Coleen Phillimore wrote:
>>> Summary: note all MemberNames created on internal list for adjusting 
>>> method entries.
>>>
>>> The JVM MemberNameTable code will push all member names on the list 
>>> rather than trying to index by method_idnum.  The code to look up 
>>> MemberName types wasn't used so was removed.  Class redefinition 
>>> iterates through the table sequentially to update the Method* 
>>> pointers in saved member names.
>>>
>>> This change will work with David Chase's change to the Java code for 
>>> bug 8013267 without the extra code dealing with class redefinition.
>>>
>>> Tested with vm.quick.testlist, jck tests and jtreg tests, including 
>>> the mlvm tests that failed in the bug report.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8042235/
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8042235
>>>
>>> Thanks,
>>> Coleen
>>
>



More information about the hotspot-dev mailing list