RFR(XS): 8065915: Fix includes after 8058148: MaxNodeLimit and LiveNodeCountInliningCutoff

David Holmes david.holmes at oracle.com
Wed Nov 26 01:32:33 UTC 2014


On 26/11/2014 1:06 AM, Lindenmaier, Goetz wrote:
> Hi,
>
> please review and sponsor this tiny fix:
>
> http://cr.openjdk.java.net/~goetz/webrevs/8065915-inclFix/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8065915
>
> It needs to go to hotspot-comp.
>
> 8058148 includes compile.hpp in ciTypeFlow.cpp. compile.hpp uses locate_node_notes() which is defined inline in node.hpp. Therefore ciTypeFlow.cpp also must include node.hpp. This breaks the build.

If compile.hpp uses things from node.hpp then shouldn't it include node.hpp?

David

> opto/compile.hpp:825: warning: inline function 'Node_Notes* Compile::locate_node_notes(GrowableArray<Node_Notes*>*, int, bool)' used but never defined
>
> Best regards,
>    Goetz.
>


More information about the hotspot-dev mailing list