RFR(XS): 8065915: Fix includes after 8058148: MaxNodeLimit and LiveNodeCountInliningCutoff

[Vladimir Ivanov]

Goetz, looks good to me.

Best regards,
Vladimir Ivanov

On 11/27/14, 1:45 PM, Lindenmaier, Goetz wrote:
> Hi,
>
> could somebody please have a look at this really tiny change?
> Maybe you, Vladimir I.?
> 8058148 arrived in jdk8, so this one needs to go there, too, please.
>
> It breaks the build without precompiled headers.
>
> Best regards,
>    Goetz.
>
> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Mittwoch, 26. November 2014 08:40
> To: 'David Holmes'; hotspot-dev at openjdk.java.net; Vladimir Ivanov
> Subject: RE: RFR(XS): 8065915: Fix includes after 8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
>
> Hi David
>
> If I remember correctly that causes bigger problems because of some cyclic dependencies or the like.
> But I didn't try it this time.
>
> The best thing would be to introduce node.inline.hpp ... But here I just want to fix the build.
>
> Best regards,
>    Goetz
>
> -----Original Message-----
> From: David Holmes [mailto:david.holmes at oracle.com]
> Sent: Mittwoch, 26. November 2014 02:33
> To: Lindenmaier, Goetz; hotspot-dev at openjdk.java.net; Vladimir Ivanov
> Subject: Re: RFR(XS): 8065915: Fix includes after 8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
>
> On 26/11/2014 1:06 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> please review and sponsor this tiny fix:
>>
>> http://cr.openjdk.java.net/~goetz/webrevs/8065915-inclFix/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8065915
>>
>> It needs to go to hotspot-comp.
>>
>> 8058148 includes compile.hpp in ciTypeFlow.cpp. compile.hpp uses locate_node_notes() which is defined inline in node.hpp. Therefore ciTypeFlow.cpp also must include node.hpp. This breaks the build.
>
> If compile.hpp uses things from node.hpp then shouldn't it include node.hpp?
>
> David
>
>> opto/compile.hpp:825: warning: inline function 'Node_Notes* Compile::locate_node_notes(GrowableArray<Node_Notes*>*, int, bool)' used but never defined
>>
>> Best regards,
>>     Goetz.
>>