RFR (XS) 8059474: Clean up vm/utilities/Bitmap type uses

Aleksey Shipilev aleksey.shipilev at oracle.com
Wed Oct 1 07:23:59 UTC 2014


Thanks for review, Coleen!

Any GC guys around? Please take a look.

-Aleksey.

On 10/01/2014 02:10 AM, Coleen Phillimore wrote:
> 
> Aleksey,
> 
> This looks good to me.  GC code uses BitMap a lot and JPRT tests the
> different collectors so I think this is fine.  Someone from the GC team
> should look at this also.
> 
> Thanks!
> Coleen
> 
> 
> On 9/30/14, 11:03 AM, Aleksey Shipilev wrote:
>> Hi,
>>
>> Not sure which group this belongs to, using the generic hotspot-dev at .
>>
>> vm/utilities/BitMap inconsistencies bugged me for quite some time: the
>> mention of naked uintptr_t instead of properly typedef-ed bm_word_t
>> alias; casting AllBits/NoBits constants of (luckily) the same type;
>> other things like a benign inconsistency in init_pop_count_table
>> new/free, etc.
>>
>> Here is a cleanup, please review:
>>    http://cr.openjdk.java.net/~shade/8059474/webrev.00/
>>    https://bugs.openjdk.java.net/browse/JDK-8059474
>>
>> Testing:
>>    JPRT, Nashorn/Octane on Linux/x86_64/fastdebug.
>>
>> Thanks,
>> -Aleksey.
>>
> 




More information about the hotspot-dev mailing list