RFR(L): JDK-8057777 Cleanup of old and unused VM interfaces
harold seigel
harold.seigel at oracle.com
Fri Oct 3 12:54:07 UTC 2014
Hi Fred,
It's great to see all this code go away.
Since JVM_AllocateNewObject() is getting removed, can
JavaCalls::call_default_constructor() also be removed?
Also, why were JVM_DesiredAssertionStatus and JVM_DoPrivileged moved in
make/solaris/makefiles/mapfile-vers ? They are no longer in
alphabetical order.
Thanks, Harold
On 10/1/2014 9:50 AM, Frederic Parain wrote:
> Thanks Coleen,
>
> Fred
>
> On 10/01/2014 12:01 AM, Coleen Phillimore wrote:
>>
>> Fred,
>>
>> I reviewed this change. It looks great. Some of the functions removed
>> seem to be not only unused but dangerous. Some of these I have made
>> changes to that I didn't realize that the JVM didn't use these
>> functions. Thank you for doing this!
>>
>> Coleen
>>
>> On 9/30/14, 10:40 AM, Frederic Parain wrote:
>>> Hi all,
>>>
>>> Please review changes for bug JDK-8057777 "Cleanup of old
>>> and unused VM interfaces"
>>>
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8057777
>>>
>>> This is basically a big cleanup of VM interfaces that are
>>> not used anymore by the JDK but have been kept in our code
>>> base for historical reasons (HotSpot Express for instance).
>>> These changesets remove these interfaces from both the
>>> JDK and the HotSpot side, and also perform some cleanup
>>> on code that directly referenced the removed interfaces.
>>>
>>> These changes do not modify the behavior of the Java
>>> classes impacted by the cleanup.
>>>
>>> VM interfaces removal has been approved by CCC and
>>> a Release Note has been prepared that explicitly list
>>> all the removed interfaces.
>>>
>>> Testing: JPRT hotspot + core, vm.quick.testlist, jdk_core
>>>
>>> Webrevs:
>>> http://cr.openjdk.java.net/~fparain/8057777/
>>>
>>> Thank you,
>>>
>>> Fred
>>>
>>
>
More information about the hotspot-dev
mailing list