RFR (XS) 8060245: update bsd version of jhelper.d to be in sync with the fix of 8009204 on solaris
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Wed Oct 15 05:48:30 UTC 2014
Hi Coleen,
Thank you for looking at it!
Do you mean to move the jhelper.d + deps from bsd to posix?
I don't know how to answer your question.
What I understand is the jhelper.d has never been tested on bsd platform.
It can be a reason why there is almost no difference with solaris yet.
In order to use the jhelper.d the dtrace framework on bsd (or posix)
must support helpers
in a similar way as it is done on solaris and implement jstack action.
I'd do as minimal as possible here until any commitment is seen in this
area.
It is not clear why the jhelper.d was ported on bsd in the first place.
Please, let me know what is your opinion.
Thanks,
Serguei
In general, I have a question
On 10/14/14 11:41 AM, Coleen Phillimore wrote:
>
> Serguei,
>
> Could the jhelper.d files be put in src/os/posix/dtrace since they
> only differ by the mangled name for Method::vtable?
>
> Thanks,
> Coleen
>
>
> On 10/13/14, 5:29 PM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>> https://bugs.openjdk.java.net/browse/JDK-8060245
>>
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/8060245-dtrace.1/
>>
>>
>>
>> Summary:
>>
>> The fix of 8009204 for jhelper.d was applied to the Solaris
>> version only but the bsd version must match it too.
>>
>>
>> Testing:
>> N/A: The jhelper.d is not used on bsd yet
>>
>>
>> Thanks,
>> Serguei
>
More information about the hotspot-dev
mailing list