RFR: 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse

Coleen Phillimore coleen.phillimore at oracle.com
Wed Oct 15 13:20:43 UTC 2014


On 10/15/14, 8:08 AM, Stefan Karlsson wrote:
>>
>> I think since the abstraction has been broken that metadata_do() 
>> should be rewritten so that it shares the code that duplicates the 
>> walks in
>> nmethod::mark_metadata_on_stack_at
>> nmethod::mark_metadata_on_stack_non_relocs()
>
> You mean something like this?:
> http://cr.openjdk.java.net/~stefank/8056240/webrev.02.do_metadata.delta
> http://cr.openjdk.java.net/~stefank/8056240/webrev.02.do_metadata
>

No, I meant more like not having do_metadata() and just calling 
mark_on_stack directly like you did in your new functions and removing 
metadata_do().   The only other use is in CheckClass and we could have 
the copy of metadata walking there too.  So there would be 2 copies of 
the walk but they didn't generalize well anyway.  And there is too much 
indirection.

I'll file an RFE (if you haven't already).

Coleen


More information about the hotspot-dev mailing list