RFR(S): 8061443: Whitebox get*VMFlag() methods fail with develop flags in product builds

[David Holmes]

Hi Tobias,

On 21/10/2014 11:08 PM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8061443
> Webrev: http://cr.openjdk.java.net/~thartmann/8061443/webrev.00/
>
> Problem:
> The Whitebox API methods get*VMFlag() fail with develop/notproduct flags in
> product builds.
>
> Solution:
> The code is changed to invoke 'Flag::find_flag' with allow_locked=true and
> return_flag=true to return both locked and notproduct/develop flags. I also
> changed the JVM monitoring and management code 'jmm_GetVMGlobals()'.

Why did you change the jmm code? You seemed to have changed its 
semantics - which may require a CCC request.

Thanks,
David

> I adapted the existing tests to check for develop flags as well. I noticed that
> HotspotDiagnosticMXBean.getVMOption() fails with double flags and filed
> JDK-8061616 [1].
>
> Testing:
> - New testcases
> - JPRT
>
> Thanks,
> Tobias
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8061616
>