RFR: 8u40: Thread and management extension support

[Mikael Gerdin]

Stefan,

On Thursday 04 September 2014 08.43.39 Stefan Johansson wrote:
> Thanks Mikael for looking at this.
> 
> On 2014-09-04 08:19, Mikael Gerdin wrote:
> > Hi Stefan,
> > 
> > On Wednesday 03 September 2014 16.34.06 Stefan Johansson wrote:
> >> Hi,
> >> 
> >> Please review these changes to allow thread and management extensions in
> >> the VM.
> >> http://cr.openjdk.java.net/~sjohanss/thread-ext/webrev.00/
> > 
> > This looks like a pretty clean refactoring to allow further extensions
> > with
> > per-thread data.
> > 
> > It looks like you removed a random newline in the Thread constructor and
> > another newline in the Thread class declaration.
> 
> Fixed.
> 
> > thread_ext.cpp should only need two includes:
> > precompiled.hpp and thread_ext.hpp it does not reference anything in the
> > Thread class.
> 
> Fixed.
> 
> > I've verified that the code which is moved outside INCLUDE_MANAGEMENT in
> > management.cpp is a clean copy.
> > 
> > With those small nits fixed immediately or deferred for future cleanup
> > this
> > looks good to me.
> 
> New webrev at:
> http://cr.openjdk.java.net/~sjohanss/thread-ext/webrev.01/

Looks good.

/Mikael

> 
> Stefan
> 
> > /Mikael
> > 
> >> There is currently no JBS issue open for this issue but one will be open
> >> shortly.
> >> 
> >> Best regards,
> >> Stefan